Hey, it's a start! It takes time to learn how to compose. Keep in mind, a "beat" is synonymous with a "rhythm"... but that is not the same as a song. Take it one step at a time. You mentioned kicks on 1 and 2, and snares on 2 and 4... Not entirely sure about standard hip hop drums, but a kick on 1 and 2 only might sound a bit empty as far as a rhythm goes. 2 and 4 for the snares is definitely the most common pattern for 4/4 time signatures. If you are recording MIDI from a controller, don't be afraid to use quantize functions or manual editing for timing or note information. It can be difficult to get the timing right, especially if your system has a lot of latency (delay on recording/input). The sounds you chose sound good, just seems that you need to practice, which is what you are doing. Keep at it!
on Beat Demo by ChaseMercata